SL-19286 Avatar is upside down when viewed from below #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Jun 7, 2023
akleshchev
reviewed
Jun 7, 2023
| // A dot B = mag(A) * mag(B) * cos(angle between A and B) | ||
| // so... cos(angle between A and B) = A dot B / mag(A) / mag(B) | ||
| // = A dot B for unit vectors | ||
|
|
||
| LLVector3 skyward = getReferenceUpVector(); | ||
|
|
||
| const F32 look_down_limit = 179.f * DEG_TO_RAD;; | ||
| const F32 look_up_limit = 1.f * DEG_TO_RAD; | ||
| const F32 look_up_limit = 10.f * DEG_TO_RAD; |
There was a problem hiding this comment.
So it's going to reserve 10 degrees intead of 1? Please leave a comment in code that explains why this value was choosen.
There was a problem hiding this comment.
Do you see any comment about 179 degrees? :-)
This value was chosen empirically, the issue is observed on lower values
There was a problem hiding this comment.
I mean a comment like "10 degrees dead zone was choosen to avoid issues with vamera flipping", lets not follow bad practices.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
github-actions
bot
removed
llappearance
llrender
llcharacter
llcorehttp
llui
llmessage
llxml
llmath
labels
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatar is upside down when viewed from below after left-clicking the mouse on the avatar and dragging down