SL-18977 Borders of inventory view in inventory floater seem to be cut a bit #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Jun 9, 2023
|
|
akleshchev
reviewed
Jun 9, 2023
| @@ -126,6 +126,7 @@ LLScrollContainer::LLScrollContainer(const LLScrollContainer::Params& p) | |||
|
|
|||
| LLRect horizontal_scroll_rect = mInnerRect; | |||
| horizontal_scroll_rect.mTop = horizontal_scroll_rect.mBottom + scrollbar_size; | |||
| horizontal_scroll_rect.mLeft += 3; | |||
There was a problem hiding this comment.
'3' in this case is a 'magic number', please use a const variable, like HORIZONTAL_SCROLL_LEFT_PAD.
There was a problem hiding this comment.
On screen it looks like horizontal scroll overlaps vertical scroll, are you sure you don't need to reduce width by the same 3 pixels?
akleshchev
approved these changes
Jun 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.