Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back mul_mat4_vec3 to scalar implementation to attempt crash mitigation #3468

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fall back mul_mat4_vec3 to scalar implementation to attempt crash mitigation #3468

merged 1 commit into from
Jan 24, 2025

Conversation

RyeMutt
Copy link
Contributor

@RyeMutt RyeMutt commented Jan 23, 2025 •
edited
Loading

  • Fall back mul_mat4_vec3 to scalar implementation to attempt crash mitigation
  • Fix potential buffer overruns when converting LLVector3/4 to glm:vec3/4

#3339

@RyeMutt
Fix potential undefined behavior when converting to and from glm type…
4763195 
…s from LLVector3/4 and fall back mul_mat4_vec3 to scalar implementation to attempt crash mitigation (#3339)
@RyeMutt RyeMutt requested review from akleshchev and Geenz January 23, 2025 23:45
@RyeMutt RyeMutt merged commit aa02a5b into release/2024.12-ForeverFPS Jan 24, 2025
11 checks passed
@RyeMutt RyeMutt deleted the rye/forever-3339 branch January 24, 2025 04:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Geenz Geenz Geenz approved these changes

@akleshchev akleshchev akleshchev approved these changes

Assignees
No one assigned
Labels
c/cpp llmath llrender
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyeMutt @Geenz @akleshchev