Review of PEM format quickfix #54 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This quickfix changes the PEM format from PKSC8 to PKSC5 (TraditionalOpenSSL) in pyca_crypto's variant of `create_rsa_encrypted_pem`. PKSC5 has the PEM headers expected by other PEM parsing functions, e.g. `is_pem_private` and `extract_pem`. See secure-systems-lab#54 for more details
Test the output of `create_rsa_encrypted_pem` in conjunction with PEM parsing functions `extract_pem` and `is_private_pem`.
As @vladimir-v-diaz points out, comments and docstrings for securesystemslib/pyca_crypto_keys.py's `create_rsa_encrypted_pem` are outdated. This commit updates docstring, comments and some indentation guideline mismatches.
Following @vladimir-v-diaz's review suggestions, this commit fixes some variable names and indentations in `test_keys.py`
As @vladimir-v-diaz points out, comments and docstrings for securesystemslib/pyca_crypto_keys.py's `create_rsa_encrypted_pem` are outdated. This commit updates docstring, comments and some indentation guideline mismatches.
Following @vladimir-v-diaz's review suggestions, this commit fixes some variable names and indentations in `test_keys.py`
…systemslib into lukpueh-pem-format-quickfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge and test #57 with master.