Feature: G101 match variable values and names #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccojocar
approved these changes
Jun 14, 2023
|
There are some lint issues. Please could you fix them? |
|
Don't mean to butt in here, just really excited about |
houndci-bot
reviewed
Jun 14, 2023
Thanks for the suggestions on my code changes. Please me know if there are any further suggestions or anything.
I think I fixed them, I do not see any more issues on when running golangci-lint locally. I have no further changes unless anything else comes up. |
|
@morgenm Thanks for addressing all review comments. The change looks good now. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the HardcodedCredentials code to apply regex against the actual values themselves in assignment statements, valuespecs, and equalities. The intention is to search for secrets, such as API keys, by looking for the values. For example if we have:
key = "3490b39bc66f7e7730e8fa68041da2e4f7c0a6a8cb119466c3ddc5245bda1781"this would previously not be caught by gosec, because gosec only looks at the variable names.
Now, with these changes, the code matches values too using a new regex pattern that will look for secrets such as this. I added a new config variable called "patternValue," with a default regex which searches for VirusTotal API keys (or other keys with the same format).