Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-register SecretSwap Pair #79

Closed
DrPresident opened this issue Sep 3, 2021 · 2 comments · Fixed by #149
Closed

Un-register SecretSwap Pair #79

DrPresident opened this issue Sep 3, 2021 · 2 comments · Fixed by #149
Labels
oracle New feature or request for the oracle contract

Comments

@DrPresident
Copy link
Collaborator

After registering a Pair for say SETH, there is currently no way to undo this and get_price(SETH) will always query secretswap, in the case of a misconfig or an asset we no longer want to support there should be a method to remove/invalidate that secretswap pair with an authorized message.

@mohammedpatla
Copy link
Member

Oh so we are stuck with Secret Swap once set

@DrPresident
Copy link
Collaborator Author

For example currently if you were to register the SHD/SSCRT pair for the SHD price feed, there is no way to undo this action. Its simple to add in the removal function but I think it will be important for re-configuration.

@DrPresident DrPresident added the oracle New feature or request for the oracle contract label Dec 19, 2021
@DrPresident DrPresident linked a pull request Dec 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oracle New feature or request for the oracle contract
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants