Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oracle] Unregister Secret Swap pair #149

Merged

Conversation

LasTshaMAN
Copy link
Contributor

@LasTshaMAN LasTshaMAN commented Dec 19, 2021

Closes #79.

A basic implementation for unregestering Secret Swap pair by symbol (specifying symbol seems to be sufficient since the only supported pairs are of the form: */SCRT or SSCRT/*).

Copy link
Collaborator

@DrPresident DrPresident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some non-blocking comments, most important one is about the ? but looks good!

contracts/oracle/src/handle.rs Outdated Show resolved Hide resolved
packages/shade_protocol/src/oracle.rs Outdated Show resolved Hide resolved
packages/shade_protocol/src/oracle.rs Outdated Show resolved Hide resolved
@DrPresident DrPresident added the oracle New feature or request for the oracle contract label Dec 19, 2021
@DrPresident DrPresident linked an issue Dec 19, 2021 that may be closed by this pull request
Copy link
Collaborator

@DrPresident DrPresident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LasTshaMAN LasTshaMAN force-pushed the oracle-unregister-sswap-pair branch from c02214f to cbcdfa2 Compare December 23, 2021 07:34
@FloppyDisck
Copy link
Contributor

@DrPresident feel free to merge this in if you think this PR is ready

@DrPresident DrPresident merged commit 0fe97b2 into securesecrets:dev Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oracle New feature or request for the oracle contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-register SecretSwap Pair
3 participants