-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oracle] Unregister Secret Swap pair #149
[oracle] Unregister Secret Swap pair #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some non-blocking comments, most important one is about the ?
but looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
c02214f
to
cbcdfa2
Compare
@DrPresident feel free to merge this in if you think this PR is ready |
Closes #79.
A basic implementation for unregestering Secret Swap pair by symbol (specifying
symbol
seems to be sufficient since the only supported pairs are of the form:*/SCRT
orSSCRT/*
).