Governance | pre voting #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloppyDisck
requested review from
chris-ricketts,
DrPresident and
wahlbergkyle
This was
linked to
issues
Nov 4, 2021
Closed
DrPresident
approved these changes
Nov 10, 2021
# Conflicts: # contracts/governance/src/contract.rs # contracts/governance/src/handle.rs # packages/network_integration/src/contract_helpers/initializer.rs
# Conflicts: # packages/network_integration/src/contract_helpers/initializer.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proposal funding period to limit proposal spamming. The created proposals are placed in a funding period much like the voting period where users must fund and reach a certain limit, if that limit is reached before the funding deadline the proposal will go into a voting period and return all of the funds to their respective users, if the limit is not reached then it will be sent to treasury (currently not implemented since im waiting for treasury funding handles)
Another thing that was added was more efficient storage for proposal related information, for example votes, amounts, deadlines and status are in their respective storages, this allows for cheaper serialization/deserialization.