Add experimental support for forcing D2D transfer backups #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
from
34273a6 to
a7e29e5
Compare
|
We probably need to do #484 cleanly first. Did you not encounter that issue in your tests? |
|
Didn't test this just yet but I had done tests with the original D2D branch in the emulator and it didn't have this problem (I produced the static test data backup from that branch). I also think it didn't have 300 packages though. |
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
3 times, most recently
from
482469e to
66f0640
Compare
3 tasks
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
2 times, most recently
from
6e14477 to
d8aba14
Compare
Change-Id: Ieab13cb15b64e09798ec0c1081d3b3cd975e0811
Allow backup of apps that would otherwise only support device-to-device migration. This is an initial-support patch to help determine the viability of this approach. Known issues / TODO: * System-scheduled backups will not handle D2D-only apps, unless accompanied by a framework change forcing OperationType.MIGRATION. Backups triggered by the connection of a USB device or by Seedvault's StorageBackupService (files) scheduling are not affected, so they *will* back up D2D-only apps as expected; otherwise, the user may need to perform a backup manually via Backup Now. * Apps with `allowBackup="false"` will appear in Backup Status under "Installed Apps" rather than "Apps that do not allow data backup", and their status will always be blank until they have been backed up. If they are not eligible for migration, it will never change. Other notes: * The unit test for excluding the Storage Plugin provider from backups was discussed, deemed unnecessary, and removed. Co-authored-by: Oliver Scott <[email protected]> Change-Id: I5a23d68be66f7d8ed755f2bccb9570ab7be49356
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
from
d8aba14 to
1c75783
Compare
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
from
1c75783 to
2ad9266
Compare
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
5 times, most recently
from
3661914 to
fa4c52f
Compare
|
There's still a DO NOT MERGE commit in this PR. Can we remove that? |
grote
requested changes
Jan 2, 2024
app/src/main/java/com/stevesoltys/seedvault/transport/backup/PackageService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/transport/backup/PackageService.kt
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/transport/restore/RestoreCoordinator.kt
Show resolved
Hide resolved
app/src/test/java/com/stevesoltys/seedvault/transport/backup/BackupCoordinatorTest.kt
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/transport/backup/PackageService.kt
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/transport/backup/BackupCoordinator.kt
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/transport/backup/PackageService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/transport/backup/PackageService.kt
Show resolved
Hide resolved
* Bump version * 33030020 -> 13-3.2 * 33030021 -> This, d2d test #478 * 33030022 -> Next, to go back to normal build after testing #489 * Set the testing property to true so that the system sends us the right app list 14597: Optionally have System-scheduled backups act as migrations | https://review.calyxos.org/c/CalyxOS/platform_frameworks_base/+/14597 Change-Id: I278091b6659db095716e01b6c3894ce345219283
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
5 times, most recently
from
15574cd to
bacfc20
Compare
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
from
bacfc20 to
fe27f82
Compare
grote
reviewed
Jan 5, 2024
app/src/main/java/com/stevesoltys/seedvault/transport/restore/RestoreCoordinator.kt
Show resolved
Hide resolved
grote
reviewed
Jan 5, 2024
app/src/test/java/com/stevesoltys/seedvault/transport/backup/BackupCoordinatorTest.kt
Outdated
Show resolved
Hide resolved
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
5 times, most recently
from
a88af6f to
7af5dd8
Compare
stevesoltys
force-pushed
the
feature/d2d-transfer
branch
from
7af5dd8 to
daaf0e0
Compare
grote
approved these changes
Jan 15, 2024
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a toggle in expert settings which enables D2D transfers for backups. Each backup will have a flag in the metadata indicating whether or not it was produced with the D2D transfer toggle enabled.