Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 'Launch' button for force stopped apps in backup status screen #786

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

grote
Copy link
Collaborator

@grote grote commented Oct 30, 2024

No description provided.

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
in backup status screen.
@grote grote requested a review from t-m-w October 30, 2024 15:18
@t-m-w
Copy link
Collaborator

t-m-w commented Oct 31, 2024

This seems to work just fine, except for apps that by design cannot be launched:

An optional very-wishlist item would be a way to indicate to the user that the app is no longer stopped (if we even know) and should be backed up on the next run.

Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launched some apps that hadn't been backed up, using this new button. Ran backup again. They're all good now.

@grote
Copy link
Collaborator Author

grote commented Oct 31, 2024

This seems to work just fine, except for apps that by design cannot be launched

I wonder why these apps show up there at all. The expectation is that the only system apps it shows there are the launchable ones.

@grote grote merged commit e19be55 into seedvault-app:android15 Oct 31, 2024
2 checks passed
@grote
Copy link
Collaborator Author

grote commented Oct 31, 2024

An optional very-wishlist item would be a way to indicate to the user that the app is no longer stopped (if we even know) and should be backed up on the next run.

Sounds worthy of a ticket :P

@grote grote deleted the show-app-size branch October 31, 2024 19:27
@t-m-w
Copy link
Collaborator

t-m-w commented Oct 31, 2024

An optional very-wishlist item would be a way to indicate to the user that the app is no longer stopped (if we even know) and should be backed up on the next run.

Sounds worthy of a ticket :P

All right, done here: #788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants