Try to fix ESLint ConfigErrors

.changeset/fifty-nails-swim.md

@@ -0,0 +1,7 @@
+---
+'eslint-config-skuba': patch
+---
+
+Remove duplicate `@typescript-eslint` definitions
+
+These configs already defined in `eslint-config-seek/base` 14.

.changeset/three-rings-argue.md

@@ -0,0 +1,7 @@
+---
+'eslint-config-skuba': minor
+---
+
+Remove `eslint-plugin-tsdoc`
+
+This plugin is [currently incompatible](https://github.com/microsoft/tsdoc/issues/374) with our config.

packages/eslint-config-skuba/index.js

@@ -1,8 +1,6 @@
 const base = require('eslint-config-seek/base');
 const extensions = require('eslint-config-seek/extensions');
-const tsdoc = require('eslint-plugin-tsdoc');
 const eslintPluginYml = require('eslint-plugin-yml');
-const tseslint = require('typescript-eslint');
 
 const { js: jsExtensions, ts: tsExtensions } = extensions;
 
@@ -88,13 +86,6 @@ module.exports = [
       ],
     },
   },
-  ...[
-    ...tseslint.configs.recommendedTypeChecked,
-    ...tseslint.configs.stylisticTypeChecked,
-  ].map((config) => ({
-    ...config,
-    files: [`**/*.{${tsExtensions}}`],
-  })),
   {
     files: [`**/*.{${tsExtensions}}`],
 
@@ -136,17 +127,6 @@ module.exports = [
       '@typescript-eslint/no-unsafe-member-access': 'off',
     },
   },
-  {
-    files: [`**/*.{${tsExtensions}}`],
-
-    plugins: {
-      tsdoc,
-    },
-
-    rules: {
-      'tsdoc/syntax': 'error',
-    },
-  },
   {
     files: [`**/*.test.{${tsExtensions}}`, `**/testing/**/*.{${tsExtensions}}`],
 

packages/eslint-config-skuba/package.json

@@ -27,7 +27,6 @@
   },
   "dependencies": {
     "eslint-config-seek": "^14.0.1",
-    "eslint-plugin-tsdoc": "^0.4.0",
     "eslint-plugin-yml": "^1.14.0",
     "typescript-eslint": "^8.16.0"
   },

src/cli/lint.test.ts

@@ -96,7 +96,6 @@ describe('TypeScript', () => {
     test('Stricter Checks For The in Operator', () => {
       const flag = true;
 
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-expect-error
       expect(flag ? true : 'foo' in 42).toBeDefined();
     });
@@ -135,16 +134,14 @@ describe('TypeScript', () => {
 
     test('override and the --noImplicitOverride flag', () => {
       class SomeComponent {
-        // eslint-disable-next-line @typescript-eslint/no-empty-function
         show() {}
-        // eslint-disable-next-line @typescript-eslint/no-empty-function
+
         hide() {}
       }
 
       class SpecializedComponent extends SomeComponent {
-        // eslint-disable-next-line @typescript-eslint/no-empty-function
         override show() {}
-        // eslint-disable-next-line @typescript-eslint/no-empty-function
+
         override hide() {}
       }
 
@@ -168,7 +165,6 @@ describe('TypeScript', () => {
           return null;
         }
 
-        // eslint-disable-next-line @typescript-eslint/no-empty-function
         static #someStaticMethod() {}
 
         somePublicMethod() {

src/cli/lint/internalLints/upgrade/index.ts

@@ -61,7 +61,6 @@ const fileExtensions = ['js', 'ts'];
 const resolvePatches = async (version: string): Promise<Patches> => {
   for (const extension of fileExtensions) {
     try {
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
       return (await import(`./patches/${version}/index.${extension}`)).patches;
     } catch {
       // Ignore