[fold] continueCallback should be passed by const&

src/ripple/app/paths/PathRequest.cpp

@@ -470,7 +470,7 @@ PathRequest::getPathFinder(
     Currency const& currency,
     STAmount const& dst_amount,
     int const level,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     auto i = currency_map.find(currency);
     if (i != currency_map.end())
@@ -496,7 +496,7 @@ PathRequest::findPaths(
     std::shared_ptr<RippleLineCache> const& cache,
     int const level,
     Json::Value& jvArray,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     auto sourceCurrencies = sciSourceCurrencies;
     if (sourceCurrencies.empty() && saSendMax)
@@ -650,7 +650,7 @@ Json::Value
 PathRequest::doUpdate(
     std::shared_ptr<RippleLineCache> const& cache,
     bool fast,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     using namespace std::chrono;
     JLOG(m_journal.debug())

src/ripple/app/paths/PathRequest.h

@@ -100,7 +100,7 @@ class PathRequest final : public InfoSubRequest,
     doUpdate(
         std::shared_ptr<RippleLineCache> const&,
         bool fast,
-        std::function<bool(void)> continueCallback = {});
+        std::function<bool(void)> const& continueCallback = {});
     InfoSub::pointer
     getSubscriber();
     bool
@@ -117,7 +117,7 @@ class PathRequest final : public InfoSubRequest,
         Currency const&,
         STAmount const&,
         int const,
-        std::function<bool(void)>);
+        std::function<bool(void)> const&);
 
     /** Finds and sets a PathSet in the JSON argument.
         Returns false if the source currencies are inavlid.
@@ -127,7 +127,7 @@ class PathRequest final : public InfoSubRequest,
         std::shared_ptr<RippleLineCache> const&,
         int const,
         Json::Value&,
-        std::function<bool(void)>);
+        std::function<bool(void)> const&);
 
     int
     parseJson(Json::Value const&);

src/ripple/app/paths/Pathfinder.cpp

@@ -207,7 +207,7 @@ Pathfinder::Pathfinder(
 bool
 Pathfinder::findPaths(
     int searchLevel,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     JLOG(j_.trace()) << "findPaths start";
     if (mDstAmount == beast::zero)
@@ -423,7 +423,7 @@ Pathfinder::getPathLiquidity(
 void
 Pathfinder::computePathRanks(
     int maxPaths,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     mRemainingAmount = convertAmount(mDstAmount, convert_all_);
 
@@ -503,7 +503,7 @@ Pathfinder::rankPaths(
     int maxPaths,
     STPathSet const& paths,
     std::vector<PathRank>& rankedPaths,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     JLOG(j_.trace()) << "rankPaths with " << paths.size() << " candidates, and "
                      << maxPaths << " maximum";
@@ -582,7 +582,7 @@ Pathfinder::getBestPaths(
     STPath& fullLiquidityPath,
     STPathSet const& extraPaths,
     AccountID const& srcIssuer,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     JLOG(j_.debug()) << "findPaths: " << mCompletePaths.size() << " paths and "
                      << extraPaths.size() << " extras";
@@ -723,7 +723,7 @@ Pathfinder::getPathsOut(
     AccountID const& account,
     bool isDstCurrency,
     AccountID const& dstAccount,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     Issue const issue(currency, account);
 
@@ -787,7 +787,7 @@ Pathfinder::addLinks(
     STPathSet const& currentPaths,  // The paths to build from
     STPathSet& incompletePaths,     // The set of partial paths we add to
     int addFlags,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     JLOG(j_.debug()) << "addLink< on " << currentPaths.size()
                      << " source(s), flags=" << addFlags;
@@ -802,7 +802,7 @@ Pathfinder::addLinks(
 STPathSet&
 Pathfinder::addPathsForType(
     PathType const& pathType,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     JLOG(j_.warn()) << "addPathsForType " << pathType;
     // See if the set of paths for this type already exists.
@@ -945,7 +945,7 @@ Pathfinder::addLink(
     const STPath& currentPath,   // The path to build from
     STPathSet& incompletePaths,  // The set of partial paths we add to
     int addFlags,
-    std::function<bool(void)> continueCallback)
+    std::function<bool(void)> const& continueCallback)
 {
     auto const& pathEnd = currentPath.empty() ? mSource : currentPath.back();
     auto const& uEndCurrency = pathEnd.getCurrency();

src/ripple/app/paths/Pathfinder.h

@@ -57,13 +57,15 @@ class Pathfinder : public CountedObject<Pathfinder>
     initPathTable();
 
     bool
-    findPaths(int searchLevel, std::function<bool(void)> continueCallback = {});
+    findPaths(
+        int searchLevel,
+        std::function<bool(void)> const& continueCallback = {});
 
     /** Compute the rankings of the paths. */
     void
     computePathRanks(
         int maxPaths,
-        std::function<bool(void)> continueCallback = {});
+        std::function<bool(void)> const& continueCallback = {});
 
     /* Get the best paths, up to maxPaths in number, from mCompletePaths.
 
@@ -76,7 +78,7 @@ class Pathfinder : public CountedObject<Pathfinder>
         STPath& fullLiquidityPath,
         STPathSet const& extraPaths,
         AccountID const& srcIssuer,
-        std::function<bool(void)> continueCallback = {});
+        std::function<bool(void)> const& continueCallback = {});
 
     enum NodeType {
         nt_SOURCE,     // The source account: with an issuer account, if needed.
@@ -133,7 +135,7 @@ class Pathfinder : public CountedObject<Pathfinder>
     STPathSet&
     addPathsForType(
         PathType const& type,
-        std::function<bool(void)> continueCallback);
+        std::function<bool(void)> const& continueCallback);
 
     bool
     issueMatchesOrigin(Issue const&);
@@ -144,22 +146,22 @@ class Pathfinder : public CountedObject<Pathfinder>
         AccountID const& account,
         bool isDestCurrency,
         AccountID const& dest,
-        std::function<bool(void)> continueCallback);
+        std::function<bool(void)> const& continueCallback);
 
     void
     addLink(
         STPath const& currentPath,
         STPathSet& incompletePaths,
         int addFlags,
-        std::function<bool(void)> continueCallback);
+        std::function<bool(void)> const& continueCallback);
 
     // Call addLink() for each path in currentPaths.
     void
     addLinks(
         STPathSet const& currentPaths,
         STPathSet& incompletePaths,
         int addFlags,
-        std::function<bool(void)> continueCallback);
+        std::function<bool(void)> const& continueCallback);
 
     // Compute the liquidity for a path.  Return tesSUCCESS if it has has enough
     // liquidity to be worth keeping, otherwise an error.
@@ -188,7 +190,7 @@ class Pathfinder : public CountedObject<Pathfinder>
         int maxPaths,
         STPathSet const& paths,
         std::vector<PathRank>& rankedPaths,
-        std::function<bool(void)> continueCallback);
+        std::function<bool(void)> const& continueCallback);
 
     AccountID mSrcAccount;
     AccountID mDstAccount;