Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade electron #632

Closed
muleyprasad opened this issue May 11, 2016 · 8 comments
Closed

Upgrade electron #632

muleyprasad opened this issue May 11, 2016 · 8 comments

Comments

@muleyprasad
Copy link

Electron have released version 1.0, nightmare needs to upgrade electon-prebuilt.
http://electron.atom.io/blog/2016/05/11/electron-1-0

@rosshinkley
Copy link
Contributor

#644 needs to be pulled in first at a minimum.

@LinusU
Copy link
Contributor

LinusU commented May 26, 2016

#644 is merged, what is next for making this happening?

@LinusU
Copy link
Contributor

LinusU commented May 31, 2016

Tried it locally with Electron 1.0.2 and seems to be working great. All tests are passing and I was able to use our internal app as before.

I'm affected by electron/electron#5444 so it would be really nice to be able to upgrade to version 1.0.2...

@rosshinkley
Copy link
Contributor

@LinusU It works fine with 1.0.x and (memory serving) 1.1.x, but some of the tests involving webSecurity break with 1.2.x. I believe it's symptoms of electron/electron#5712, which have been fixed but as yet unreleased (at least with electron-prebuilt).

I'm comfortable upgrading to a non-breaking version in the meantime, barring protest. Thoughts?

@albinekb
Copy link
Contributor

albinekb commented Jun 1, 2016

1.2.1 is released from electron, just need to wait for electron-prebuilt to upgrade

@albinekb
Copy link
Contributor

albinekb commented Jun 2, 2016

@rosshinkley @LinusU
1.2.1 is now released in electron-prebuilt https://www.npmjs.com/package/electron-prebuilt
I ran the tests with 1.2.1 and everything passes 🎉

@albinekb
Copy link
Contributor

albinekb commented Jun 7, 2016

ping @rosshinkley @matthewmueller

@rosshinkley
Copy link
Contributor

@albinekb This will get pulled into the next version. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants