Fix deprecated API usage in preload test (needed to support Electron 1.0+) #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(We fixed this in the actual preload, but missed the test!)
|
I had spotted this when working on stuff for #502, but hadn't gotten around to PRing it. Thanks! |
Closed
Oceanswave
added a commit
to Oceanswave/nightmare-promise
that referenced
this pull request
May 29, 2016
…ed in this fork)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fixed this in the actual preload script, but missed the test! This doesn’t upgrade Electron, but it is a prerequisite for upgrading. (The API is gone entirely in Electron 1.0)