Cleans up revenue logic #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeds with Tests pass with |
f2prateek
approved these changes
Oct 19, 2017
tonyxiao
reviewed
Oct 19, 2017
| quantity = [NSNumber numberWithInt:1]; | ||
| } | ||
|
|
||
| NSNumber *price = [properties objectForKey:@"price"] ?: revenueOrTotal; |
There was a problem hiding this comment.
You could use the shorthand properties[@"price"] syntax here
| id productId = [properties objectForKey:@"productId"] ?: [properties objectForKey:@"product_id"]; | ||
| if (productId && [productId isKindOfClass:[NSString class]] && ![productId isEqualToString:@""]) { | ||
| NSString *productId = [properties objectForKey:@"productId"] ?: [properties objectForKey:@"product_id"]; | ||
| if (productId && ![productId isEqualToString:@""]) { |
There was a problem hiding this comment.
This is gonna crash if productId is not a NSString for some reason. You don't have compile time guarantee, so you're better off protecting against it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useLogRevenueV2is enabled after running throughtrackLogRevenueV2