fix: make GetRoleARN support GovCloud #220
Conversation
lib/provider.go
Outdated
| return "", err | ||
| // GetRoleARN uses temporary credentials to call AWS's get-caller-identity and | ||
| // returns the assumed role's name and ARN. | ||
| func (p *Provider) GetRoleARN(creds credentials.Value) (string, error) { |
There was a problem hiding this comment.
lib.GetRoleARN was added so we could pass the credentials in without breaking API compatibility of Provider#GetRoleARN. I realize the API is gross and probably nobody imports it externally, but we can't be sure.
How about just adding a new function and method GetRoleARNWithRegion? I realize this contributes to API sprawl, but we can tackle that in v3.0
There was a problem hiding this comment.
done (and restored the old lib.GetRoleARN)!
GovCloud support was added in segmentio#197 / b4e7839 and segmentio#204 / 9787f11. Taking the role as an env var was added in segmentio#208 / 396d453, which added GetRoleARN which ignored region and, thus, broke GovCloud. Both of these were released as v0.23.0, so no version of aws-okta supported GovCloud. Separately, GetRoleARN was split into a lib function and a Provider function in segmentio#218 / e13ae0f, which left behind a code duplication TODO and an unused Provider function. This adds Provider.GetRoleARNWithRegion.
|
could we get a 0.24.2 release to pick this up? v0.24.1...master |
|
I think a release is in order but I think this might warrant a 0.25 release given that it's adding new functionality. @nickatsegment you have any issues w/ cutting v0.25.0? |
|
Yeah, kind of on the fence on that one, but meh, minor versions are cheap |
|
v0.25.0 is out and contains these changes. |
GovCloud support was added in #197 / b4e7839 and #204 / 9787f11.
Taking the role as an env var was added in #208 / 396d453, which added
GetRoleARNwhich ignored region and, thus, broke GovCloud.Both of these were released as v0.23.0, so no version of aws-okta
supported GovCloud.
Separately,
GetRoleARNwas split into alibfunction and aProviderfunction in #218 / e13ae0f, which left behind a code duplication TODO
and an unused Provider function.