Fix line break removal before package directive #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an upstream bug[1] if `golines` were to reformat (i.e. it
actually found a line that was too long) a file with a block comment
before the package directive, the newline before the package directive
would be stripped, e.g.
/*
this is a comment
*/
package foo
Would become
/*
this is a comment
*/ package foo
The underlying issue has been fixed upstream, so fix here by bumping the
version of `github.com/dave/dst` to include that fix. Here's a summary of
the changes in that package from the previously used version:
$ git log --no-merges --format='%h %s' v0.27.0..v0.27.3
5fa8d6e Fixes #69
bc71a76 Upgrade golang.org/x/tools to v0.1.12
b6f3447 decorator: make an error more verbose
[1] dave/dst#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an upstream bug[1] if
golineswere to reformat (i.e. it actually found a line that was too long) a file with a block comment before the package directive, the newline before the package directive would be stripped, e.g.Would become
The underlying issue has been fixed upstream, so fix here by bumping the version of
github.com/dave/dstto include that fix. Here's a summary of the changes in that package from the previously used version:[1] dave/dst#69