Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize lag status response format #187

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Standardize lag status response format #187

merged 2 commits into from
Jan 12, 2024

Conversation

yzang2019
Copy link
Contributor

@yzang2019 yzang2019 commented Jan 12, 2024

Describe your changes and provide context

This is to fix an issue reported: sei-protocol/sei-chain#1214

Testing performed to validate your change

Tested on local docker chain

root@6b45806c2360:/sei-protocol/sei-chain# curl localhost:26657/lag_status |jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    60  100    60    0     0   7340      0 --:--:-- --:--:-- --:--:-- 15000
{
  "current_height": "663",
  "max_peer_height": "991",
  "lag": "328"
}
root@6b45806c2360:/sei-protocol/sei-chain# curl localhost:26657/lag_status |jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    60  100    60    0     0   7483      0 --:--:-- --:--:-- --:--:-- 15000
{
  "current_height": "684",
  "max_peer_height": "991",
  "lag": "307"
}
root@6b45806c2360:/sei-protocol/sei-chain# curl localhost:26657/lag_status |jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    60  100    60    0     0   3548      0 --:--:-- --:--:-- --:--:--  6666
{
  "current_height": "694",
  "max_peer_height": "991",
  "lag": "297"
}

@yzang2019 yzang2019 merged commit da59b8d into main Jan 12, 2024
22 checks passed
stevenlanders added a commit that referenced this pull request Jan 30, 2024
* Standardize lag status response format (#187)

* Standardize lag status response format

* Fix flaky unit test

* Make ReadMaxTxs atomic (#166)

* Support pending transaction in mempool (#169)

* fix unconfirmed tx to consider pending txs (#172)

* fix pending pop (#173)

* add TTL for pending txs (#174)

* [EVM] Fix evm pending nonce (#179)

* Perf: Increase buffer size for pubsub server to boost performance (#167)

* Increase buffer size for pubsub server

* Add more timeout for test failure

* Add more timeout

* Fix test split scripts

* Fix test split

* Fix unit test

* Unit test

* Unit test

* [P2P] Optimize block pool requester retry and peer pick up logic (#170)

* P2P Improvements: Fix block sync reactor and block pool retry logic

* Revert "Add event data to result event (#165)" (#176)

This reverts commit 72bb29c.

* Fix block sync auto restart not working as expected (#175)

* Fix edge case for blocksync (#178)

* fix evm pending nonce

* fix test

* deflake a test

* de-flake test

* Revert "merge main"

This reverts commit 58b9424, reversing
changes made to 02d1478.

* consider keep-in-cache logic when removing from cache

* undo test tweaks

---------

Co-authored-by: Yiming Zang <[email protected]>
Co-authored-by: Jeremy Wei <[email protected]>

* Fix bug when popping pending TXs (#188)

* Add mempool metrics for number of pending tx and expired txs (#189)

* Add metrics for mempool pending transaction size

* Add expired tx count metrics

* [EVM] Allow multiple txs from same account in a block (#190)

* add mempool prioritization with evm nonce

* fix priority stability

* index fixes

* replace with binary search insert

* impl binary search

* fix removeTx to push next queued evm tx (#191)

* fix expire metric (#193)

* [EVM] Fix duplicate evm txs from priority queue (#195)

* debug duplicate evm tx

* add more logs

* add some \ns

* more logs

* fix swap check

* add-lockable-reap-by-gas

* add invariant checks

* fix invariant parenthesis

* fix log

* remove invalid invariant

* fix nonce ordering pain

* handle ordering of insert

* fix remove

* cleanup

* fix imports

* cleanup

* avoid getTransactionByHash(hash) panic due to index

* use Key() to compare instead of pointer

* [EVM] prevent duplicate txs from getting inserted (#196)

* prevent duplicates in mempool

* use timestamp in priority queue

* [EVM] Add logging for expiration (#198)

* add logging for expired txs

* cleanup

* [EVM] Avoid returning nil transactions on ForEach (#197)

* remove heapIndex to avoid nil scenario

* avoid returning nil in loop (mimic Peek)

---------

Co-authored-by: Yiming Zang <[email protected]>
Co-authored-by: codchen <[email protected]>
Co-authored-by: Jeremy Wei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants