Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max tx gas limit #251

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add max tx gas limit #251

wants to merge 3 commits into from

Conversation

philipsu522
Copy link
Contributor

Describe your changes and provide context

Add a config for max tx gas, and drop transactions on propose

Testing performed to validate your change

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.18%. Comparing base (57e0107) to head (3959557).

Files with missing lines Patch % Lines
internal/mempool/metrics.gen.go 66.66% 6 Missing ⚠️
internal/mempool/mempool.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   58.10%   58.18%   +0.08%     
==========================================
  Files         249      249              
  Lines       34555    34567      +12     
==========================================
+ Hits        20079    20114      +35     
+ Misses      12877    12854      -23     
  Partials     1599     1599              
Files with missing lines Coverage Δ
config/config.go 63.18% <100.00%> (+0.06%) ⬆️
internal/mempool/mempool.go 72.97% <0.00%> (-0.45%) ⬇️
internal/mempool/metrics.gen.go 15.95% <66.66%> (-0.14%) ⬇️

... and 18 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants