Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make label[for] work with selectized input #755

Closed
wants to merge 3 commits into from

Conversation

barretts
Copy link
Contributor

@barretts barretts commented Apr 2, 2015

this updates any existing labels pointing to the original input or select to point to the selectize input/select #658

maintained id uniqueness by appending '_selectized' string

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 83.25% when pulling 339abd1 on barretts:label-for into b9cd3f6 on brianreavis:master.

@barretts
Copy link
Contributor Author

barretts commented Apr 2, 2015

Not sure what to do with this, took a wild guess at the tabs, running grunt --plugins=* and then testing locally all works. The tests in https://github.com/brianreavis/selectize.js/blob/6fe97482b0f430949f6a799ef27c68479a062d7a/test/interaction.js before and after my tests use Syn.

@dvanderfaeillie
Copy link

Any plans on merging this?

@FabianKoestring
Copy link

Any plans on merging this? Really need this feature.

@TheSharpieOne
Copy link

What is the status of this?

@Pictor13
Copy link
Contributor

👍

I'd like to know about that as well.
Thank you.

@joallard joallard changed the title update existing labels pointing to the original input/select Make label[for] work with selectized input Jan 21, 2016
@joallard
Copy link
Member

Looks like the build is failing. Any idea what's up? Otherwise I'd be for it.

Ps. I'd prefer id prefix -selectize with a dash instead of underscore, no D for simplicity

@barretts
Copy link
Contributor Author

I'm not sure it's been a while since I looked at this. I'll run it again to see.

On Jan 21, 2016, at 9:25 AM, Jonathan Allard [email protected] wrote:

Looks like the build is failing. Any idea what's up?


Reply to this email directly or view it on GitHub.

@pzi
Copy link

pzi commented Apr 21, 2016

@joallard

Ps. I'd prefer id prefix -selectize with a dash instead of underscore, no D for simplicity

Yeah, I'd prefer that, too. Keeps it consistent with the rest of the classes selectize applies.

I just cloned and tested @barretts branch locally and I had 0 failures well.

Travis says Syn is not defined... however it's used everywhere else in the same file?

Would be awesome if this feature could be merged in (after a little bit more than 1 year :) ) as it would improve the forms that use selectize a lot. Any chance you get to look into it @barretts? Unfortunately, I am not very familiar with testing tools and I'd have a hard time figuring out what's wrong... otherwise I'd love to help.

Thanks & cheers
Patrik

var inputId = "labeledInput";
$('#fixture').append('<label for="'+inputId+'">input</label>');
var label = $('label[for="'+inputId+'"]');

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: While I was poking through your branch, I noticed a lot of extra WS on this line :)

@joallard joallard added this to the 0.12.3 milestone May 9, 2016
@joallard joallard modified the milestones: 0.13.0, 0.12.3 Jun 24, 2016
joallard added a commit that referenced this pull request Jul 27, 2016
- Correct tests
- Use hyphen instead of underscore in new node id
joallard added a commit that referenced this pull request Jul 27, 2016
@joallard
Copy link
Member

So merged.

@joallard joallard closed this Jul 27, 2016
joallard added a commit that referenced this pull request Jul 29, 2016
bwilson-ux pushed a commit to bwilson-ux/selectize.js that referenced this pull request Oct 4, 2016
- Correct tests
- Use hyphen instead of underscore in new node id
bwilson-ux pushed a commit to bwilson-ux/selectize.js that referenced this pull request Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants