-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make label[for] work with selectized input #755
Conversation
Not sure what to do with this, took a wild guess at the tabs, running |
Any plans on merging this? |
Any plans on merging this? Really need this feature. |
What is the status of this? |
👍 I'd like to know about that as well. |
Looks like the build is failing. Any idea what's up? Otherwise I'd be for it. Ps. I'd prefer id prefix |
I'm not sure it's been a while since I looked at this. I'll run it again to see.
|
Yeah, I'd prefer that, too. Keeps it consistent with the rest of the classes selectize applies. I just cloned and tested @barretts branch locally and I had 0 failures well. Travis says Would be awesome if this feature could be merged in (after a little bit more than 1 year :) ) as it would improve the forms that use selectize a lot. Any chance you get to look into it @barretts? Unfortunately, I am not very familiar with testing tools and I'd have a hard time figuring out what's wrong... otherwise I'd love to help. Thanks & cheers |
var inputId = "labeledInput"; | ||
$('#fixture').append('<label for="'+inputId+'">input</label>'); | ||
var label = $('label[for="'+inputId+'"]'); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: While I was poking through your branch, I noticed a lot of extra WS on this line :)
- Correct tests - Use hyphen instead of underscore in new node id
So merged. |
- Correct tests - Use hyphen instead of underscore in new node id
this updates any existing labels pointing to the original input or select to point to the selectize input/select #658
maintained id uniqueness by appending '_selectized' string