Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lte #733

Merged
merged 2 commits into from
Jun 4, 2024
Merged

feat: lte #733

merged 2 commits into from
Jun 4, 2024

Conversation

ilteoood
Copy link
Contributor

Implementation of the lte utility

@selfrefactor
Copy link
Owner

txs for the PR, but please look at the changes - there are many related to whitespace which shouldn't be included.
You can remove them or I will take the changes and include them manually.

@ilteoood
Copy link
Contributor Author

ilteoood commented Jun 2, 2024

I think are related to my vscode settings, which uses Unix new line formatting.
Is it a real problem? Are just spaces in comments 🤔

@selfrefactor
Copy link
Owner

It makes it hard to read, which for me is enough reason. Also, I have to be careful with git history of files/index.tsx as it is too important file.

@ilteoood
Copy link
Contributor Author

ilteoood commented Jun 3, 2024

@selfrefactor it should look good now

@selfrefactor
Copy link
Owner

I am approving this MR as a reward for the time you spent on it, but also because you found issue with the method declaration.

Actually, the method exists, it is just not exported due to RegEx issue.

@selfrefactor selfrefactor merged commit 901eb4b into selfrefactor:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants