Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom nullifier hashes #137

Closed
cedoor opened this issue Sep 19, 2022 · 0 comments
Closed

Custom nullifier hashes #137

cedoor opened this issue Sep 19, 2022 · 0 comments
Assignees
@cedoor
Labels
feature 🚀 This is enhancing something existing or creating something new

Comments

@cedoor
Copy link
Member

cedoor commented Sep 19, 2022

Is your feature request related to a problem? Please describe.

The way on-chain hash nullifiers are saved can change depending on the use case. Letting them be managed by the SemaphoreCore contract does not allow devs and the Semaphore.sol contract to use them differently.

Describe the solution you'd like

The nullifier hashes can be simply removed from the SemaphoreCore contract.
@cedoor cedoor added the feature 🚀 This is enhancing something existing or creating something new label Sep 19, 2022
@cedoor cedoor self-assigned this Sep 19, 2022
@cedoor cedoor moved this to 🏗 In Progress in Semaphore V2 Sep 19, 2022
@cedoor cedoor mentioned this issue Sep 19, 2022
Merged
2 tasks
@cedoor cedoor closed this as completed Sep 19, 2022
Repository owner moved this from 🏗 In Progress to ✔️ Done in Semaphore V2 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedoor cedoor

Labels
feature 🚀 This is enhancing something existing or creating something new
Projects
No open projects
Semaphore V2
Status: ✔️ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cedoor