Custom nullifier hashes #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedoor
added
the
feature 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The way on-chain hash nullifiers are saved can change depending on the use case.
This PR moves the nullifier hashes from the
SemaphoreCore.solcontract to the outside. TheSemaphore.solcontract now contains a custom mechanism for saving the nullifier hashes of each group and uses the sameGroupsstructure for all parameters used by groups.This PR also fixes a bug in the
Semaphore.solcontract, where thenullifierHashto be checked was not the correct one.Related Issue
#137
Does this introduce a breaking change?