Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts requiring specific Solidity version #259

Closed
cichaczem opened this issue Mar 1, 2023 · 3 comments
Closed

Contracts requiring specific Solidity version #259

cichaczem opened this issue Mar 1, 2023 · 3 comments
Assignees
Labels
question ❔ Further information is requested

Comments

@cichaczem
Copy link

Describe the bug

I'm using Semaphore via the git submodule. I'm working on switching from V2 to V3. When using V3, I had to downgrade the entire project from the latest Solidity version to 0.8.4 required in SemaphoreVerifier to make my contract compile.

Previous Verifier worked fine with higher versions.

Questions
Is the specific Solidity version necessary for the library to work?
Or is it possible to enable a higher version to compile this code, like it's done in Pairing.sol

@cichaczem cichaczem added the bug 🐛 Something isn't working label Mar 1, 2023
@cedoor
Copy link
Member

cedoor commented Mar 1, 2023

Hey @cichaczem, the reason why we are using fixed versions is here: #116.

Basically, it's a best practice to reduce possible vulnerabilities with other untested versions.

@cedoor cedoor self-assigned this Mar 1, 2023
@cedoor cedoor added question ❔ Further information is requested and removed bug 🐛 Something isn't working labels Mar 1, 2023
@cedoor cedoor moved this to 🏗 In Progress in Semaphore Board Mar 1, 2023
@cichaczem
Copy link
Author

Thank you for the answer. That makes sense.

Are you planning to bump the version to the latest or anything higher than 0.8.4?

@cedoor
Copy link
Member

cedoor commented Mar 8, 2023

Thank you for the answer. That makes sense.

Are you planning to bump the version to the latest or anything higher than 0.8.4?

No problem. Not yet, we'll probably bump it with Semaphore v4, but that release is still far away.

@cedoor cedoor closed this as completed Mar 8, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✔️ Done in Semaphore Board Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question ❔ Further information is requested
Projects
Status: ✔️ Done
Development

No branches or pull requests

2 participants