Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #115, Pragma Fixed #116

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix #115, Pragma Fixed #116

merged 1 commit into from
Aug 10, 2022

Conversation

TradMod
Copy link
Contributor

@TradMod TradMod commented Aug 10, 2022

Description

Floating pragmas are considered a bad practice.

It is always recommended that pragma should be fixed (not floating) to the version that you are intending to deploy your contracts with.

Related Issue

N/A

Does this introduce a breaking change?

  • Yes
  • No

Other information

For more information Check this out

Issue #115 Solved.
I hope that the Semaphore team and the community will appreciate my small contribution to this beautiful project :)

Thanks,
AB Dee.

@TradMod TradMod mentioned this pull request Aug 10, 2022
@cedoor cedoor added the refactoring ♻️ A code change that neither fixes a bug nor adds a feature label Aug 10, 2022
@cedoor cedoor merged commit 708d93c into semaphore-protocol:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
No open projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

2 participants