Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the deployed contracts to the utils package #715

Closed
vplasencia opened this issue Mar 18, 2024 · 0 comments · Fixed by #719
Closed

Add the deployed contracts to the utils package #715

vplasencia opened this issue Mar 18, 2024 · 0 comments · Fixed by #719
Assignees
@cedoor
Labels
devops 🔧 Operations management and dev tools refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Milestone
Semaphore V4 Release

Comments

@vplasencia
Copy link
Member

Description

Add the deployed contracts to the Semaphore utils package so that other packages and projects can access this info.

The idea is to create a json file with the network's info (chain id, etc.) and the deployed contract addresses. The supported-networks.ts would import that json file and export it as a js object.

Deployed contracts json file: https://github.com/semaphore-protocol/semaphore/blob/main/packages/contracts/deployed-contracts.json
@vplasencia vplasencia added the refactoring ♻️ A code change that neither fixes a bug nor adds a feature label Mar 18, 2024
@vplasencia vplasencia added this to the Semaphore V4 milestone Mar 18, 2024
@cedoor cedoor moved this to ♻️ Grooming in Semaphore Board Mar 19, 2024
@cedoor cedoor added the devops 🔧 Operations management and dev tools label Mar 21, 2024
@cedoor cedoor self-assigned this Mar 21, 2024
@cedoor cedoor moved this from ♻️ Grooming to 🏗 In Progress in Semaphore Board Mar 21, 2024
cedoor added a commit that referenced this issue Mar 21, 2024
@cedoor
feat(utils): add deployed contracts to utils package
7166713 
re #715
@cedoor cedoor moved this from 🏗 In Progress to 👀 In review in Semaphore Board Mar 21, 2024
@cedoor cedoor mentioned this issue Mar 21, 2024
Merged
9 tasks
cedoor added a commit that referenced this issue Mar 22, 2024
@cedoor
ci: build libraries first
e5de714 
re #715
cedoor added a commit that referenced this issue Mar 22, 2024
@cedoor
feat(utils): add deployed contracts to utils package
1647eca 
re #715
cedoor added a commit that referenced this issue Mar 22, 2024
@cedoor
ci: build libraries first
17d716f 
re #715
cedoor added a commit that referenced this issue Mar 22, 2024
@cedoor
chore(utils): reduce number of supported networks
095147a 
re #715
cedoor added a commit that referenced this issue Mar 22, 2024
@cedoor
chore(utils): move json of deployed contracts to utils pkg
8caad14 
re #715
cedoor added a commit that referenced this issue Mar 22, 2024
@cedoor
chore: add pre-build script for building local packages
042759b 
re #715
cedoor added a commit that referenced this issue Mar 25, 2024
@cedoor
refactor(utils): re-organize 'networks' module structure and add tests
ff3263d 
re #715
@github-project-automation github-project-automation bot moved this from 👀 In review to ✔️ Done in Semaphore Board Mar 25, 2024
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
feat(utils): add deployed contracts to utils package
619459e 
re #715


Former-commit-id: 1647eca
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
ci: build libraries first
5caa3c7 
re #715


Former-commit-id: 17d716f
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
chore(utils): reduce number of supported networks
6b659a8 
re #715


Former-commit-id: 095147a
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
chore(utils): move json of deployed contracts to utils pkg
5898a17 
re #715


Former-commit-id: 8caad14
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
chore: add pre-build script for building local packages
784cddb 
re #715


Former-commit-id: 042759b
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
refactor(utils): re-organize 'networks' module structure and add tests
8d8fb82 
re #715


Former-commit-id: ff3263d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedoor cedoor

Labels
devops 🔧 Operations management and dev tools refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
Semaphore Board
Status: ✔️ Done
Milestone
Semaphore V4 Release
Development

Successfully merging a pull request may close this issue.

Add deployed contracts to utils package semaphore-protocol/semaphore
2 participants
@cedoor @vplasencia