Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that a member is not BigInt(0) when adding members to a group in the JS implementation #717

Closed
vplasencia opened this issue Mar 20, 2024 · 0 comments · Fixed by #732
Closed

Check that a member is not BigInt(0) when adding members to a group in the JS implementation #717

vplasencia opened this issue Mar 20, 2024 · 0 comments · Fixed by #732
Assignees
@cedoor
Labels
bug 🐛 Something isn't working
Milestone
Semaphore V4 Release

Comments

@vplasencia
Copy link
Member

Description

Check that there are no BigInt(0) members when adding members in the Group class.

https://github.com/semaphore-protocol/semaphore/blob/main/packages/group/src/group.ts
@vplasencia vplasencia added the bug 🐛 Something isn't working label Mar 20, 2024
@vplasencia vplasencia added this to the Semaphore V4 milestone Mar 20, 2024
@cedoor cedoor moved this to ♻️ Grooming in Semaphore Board Mar 20, 2024
@cedoor cedoor moved this from ♻️ Grooming to 🗒 Tasks in Semaphore Board Mar 26, 2024
@cedoor cedoor self-assigned this Mar 26, 2024
@cedoor cedoor moved this from 🗒 Tasks to 🏗 In Progress in Semaphore Board Mar 28, 2024
@cedoor cedoor moved this from 🏗 In Progress to 👀 In review in Semaphore Board Mar 28, 2024
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
fix(group): add checks for removed members
65f825c 
re #717
@cedoor cedoor mentioned this issue Mar 28, 2024
Merged
9 tasks
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
fix(group): add checks for removed members
1c42ab3 
re #717
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
refactor(group): remove check on generateMerkleProof function
0014365 
Contracts actually need devs to generate a Merkle proof of a removed member.

re #717
@github-project-automation github-project-automation bot moved this from 👀 In review to ✔️ Done in Semaphore Board Mar 28, 2024
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
fix(group): add checks for removed members
ea21454 
re #717


Former-commit-id: 1c42ab3
cedoor added a commit that referenced this issue Mar 28, 2024
@cedoor
refactor(group): remove check on generateMerkleProof function
2b7dbf3 
Contracts actually need devs to generate a Merkle proof of a removed member.

re #717


Former-commit-id: 0014365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedoor cedoor

Labels
bug 🐛 Something isn't working
Projects
Semaphore Board
Status: ✔️ Done
Milestone
Semaphore V4 Release
Development

Successfully merging a pull request may close this issue.

Add checks for removed members semaphore-protocol/semaphore
2 participants
@cedoor @vplasencia