Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maybeGetSemaphoreSnarkArtifacts from @zk-kit/utils #746

Closed
sripwoud opened this issue Apr 23, 2024 · 2 comments · Fixed by #747
Closed

Use maybeGetSemaphoreSnarkArtifacts from @zk-kit/utils #746

sripwoud opened this issue Apr 23, 2024 · 2 comments · Fixed by #747
Assignees
@sripwoud
Labels
refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Milestone
Semaphore V4 Release

Comments

@sripwoud
Copy link
Contributor

Once privacy-scaling-explorations/zk-kit#240 merges and the corresponding new @zk-kit/utils package is published, we can delete all that code
https://github.com/semaphore-protocol/semaphore/blob/main/packages/proof/src/get-snark-artifacts.browser.ts
https://github.com/semaphore-protocol/semaphore/blob/main/packages/proof/src/get-snark-artifacts.node.ts

and use maybeGetSemaphoreSnarkArtifacts instead
@sripwoud
Copy link
Contributor Author

Please assign this to me ^^

@vplasencia
Copy link
Member

Hey @sripwoud! Done. Thanks.

@cedoor cedoor added the refactoring ♻️ A code change that neither fixes a bug nor adds a feature label Apr 24, 2024
@cedoor cedoor changed the title refactor: use maybeGetSemaphoreSnarkArtifacts from @zk-kit/utils Use maybeGetSemaphoreSnarkArtifacts from @zk-kit/utils Apr 24, 2024
@cedoor cedoor added this to the Semaphore V4 milestone Apr 24, 2024
@cedoor cedoor moved this to 🗒 Tasks in Semaphore Board Apr 24, 2024
@sripwoud sripwoud mentioned this issue Apr 24, 2024
Merged
9 tasks
@cedoor cedoor moved this from 🗒 Tasks to 🏗 In Progress in Semaphore Board Apr 24, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✔️ Done in Semaphore Board Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sripwoud sripwoud

Labels
refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
Semaphore Board
Status: ✔️ Done
Milestone
Semaphore V4 Release
Development

Successfully merging a pull request may close this issue.

refactor!: use maybeGetSemaphoreSnarkArtifacts from `@zk-kit/utils sripwoud/semaphore
3 participants
@cedoor @sripwoud @vplasencia