-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: use maybeGetSemaphoreSnarkArtifacts
from `@zk-kit/utils
#747
refactor!: use maybeGetSemaphoreSnarkArtifacts
from `@zk-kit/utils
#747
Conversation
…utils` Delete logic related to fetching snark artifacts (wasm and zkey files) that was moved to `@zk-kit/utils`
78a59ea
to
c15dc21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sripwoud this PR introduces a breaking change (the SnarkArtifacts
type has different property names). Worth mentioning it.
maybeGetSemaphoreSnarkArtifacts
from `@zk-kit/utilsmaybeGetSemaphoreSnarkArtifacts
from `@zk-kit/utils
Done. Update PR title and description |
b280189
to
c15dc21
Compare
79f34e2
to
bcae7be
Compare
Description
This PRs uses the
maybeGetSemaphoreSnarkArtifacts
function added in privacy-scaling-explorations/zk-kit#240.It deletes code that becomes unnecessary in
@semaphore-protocol/proof
.Notes about docs:
artifacts
in the docs, so no changes to dodownload-snark-artifacts.ts
script file, didn't do any changes there either as this PR impacts v4 onlyBreaking change
SnarkArtifacts
keys (optional param ofgenerateProof
){ wasmFilePath, zkeyFilePath }
{ wasm, zkey }
Related Issue(s)
Closes #746
Checklist
yarn prettier
andyarn lint
without getting any errors