some changes of PreImages... to NC versions #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
added
the
enhancement
|
Thanks very much @cdwensley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with Semigroiups issue #949 which arises from GAP PR #5073.
Declarations of the NC versions have been made in init.g
The two methods in gap/attributes/homomorph.gi test the input so remain non-NC.
A call in gap/attributes.factor.gi:227 has been changes to PreImagesRepresentativeNC.
In gap/attributes/isorms.gi:329,519 calls to PreImagesRepresentative are in tester functions, so remain non-NC.
In gap/attributes/isorms.gi:1109,1116 Methods for PreImagesRepresentative have been changed to NC.
No changes have been made to the doc files (isorms.xml, properties.xml, z-chap14.xml).
Tests should test, so no changes made in homomorph.tst or isorms.tst.