Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook on ConvMixer implementation #28

Merged
merged 8 commits into from
Feb 6, 2025
Merged

Conversation

BrayanQuintero123
Copy link
Contributor

@BrayanQuintero123 BrayanQuintero123 commented Nov 26, 2024

Description

implementation of the "ConvMixer" architecture presented in the paper "Patches Are All You Need?"

Checklist

Ensure your pull request meets the following requirements:

  • I have reviewed existing notebooks to avoid duplications.
  • My notebook is fully executed.
  • I have included a list of all libraries and their versions used in the notebook.
  • The notebook file is named clearly to reflect the topic (e.g., cross-entropy-loss.ipynb).
  • I have placed the notebook in the appropriate directory under notebooks/.
  • My code is simple, precise, and adheres to good coding practices..

Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the notebook name must be completely in lower case, you must also update it in the csv, see rules

@BrayanQuintero123
Copy link
Contributor Author

changes made in another commit called "change the name of the notebook and the csv name".

Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I didn't make myself understood, check the comments again, please

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in the other comment, the name of the .ipynb must be completely lowercase

@BrayanQuintero123
Copy link
Contributor Author

changes made in another commit called "Change the Csv name to lowercase".

Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the .ipynb FILEE must be completely in lowercase 😭 (ConvMixer.ipynb -> convmixer.ipynb)

@BrayanQuintero123
Copy link
Contributor Author

changes made in another commit called "only lower case".

@jorge1b3
Copy link
Member

jorge1b3 commented Feb 5, 2025

The notebooks table data file has made changes that now make conflicts with the changes that you proposed. Please fix it.

@BrayanQuintero123
Copy link
Contributor Author

changes made in another commit called "conflicts resolved with main".

Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guillepinto guillepinto merged commit 3fc85c9 into main Feb 6, 2025
@guillepinto guillepinto deleted the feat/ConvMixer branch February 6, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants