Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add themes trough shareable link as parameter #49

Closed
developer-bart opened this issue Oct 20, 2021 · 3 comments
Closed

Add themes trough shareable link as parameter #49

developer-bart opened this issue Oct 20, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@developer-bart
Copy link

developer-bart commented Oct 20, 2021

Is your feature request related to a problem? Please describe.
I want to share a Storybook component via the /iframe.html link. It's possible to add knobs as parameters like so: &knob-[key]=[value]. That doesn't seem to work for the themes.

Describe the solution you'd like
Being able to select a theme by adding a theme parameter. Is it already possible and am I missing stuff?

Describe alternatives you've considered
Changing the themes trough knobs which can be passed as parameter.

Additional context
x

@semoal semoal added the enhancement New feature or request label Oct 21, 2021
@semoal
Copy link
Owner

semoal commented Oct 21, 2021

Yes, it should be possible without much work. I'll try to find time as soon as possible =)

semoal pushed a commit that referenced this issue Oct 21, 2021
### Features

* **#49:** select themes through shareable param ([552324d](552324d)), closes [#49](#49)
@semoal
Copy link
Owner

semoal commented Oct 21, 2021

Released with 1.8.0 :) Basically adding &theme=theme.name will resolve correctly to the theme.

@semoal semoal closed this as completed Oct 21, 2021
@developer-bart
Copy link
Author

Wow thanks for the fast response! I much appreciate it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants