Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEADAS: sentinel3 reader fixes (master) #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knowles
Copy link
Contributor

@knowles knowles commented Jan 13, 2023

  1. Fixed regular expression in MerisLevel1ProductReader to match the corrected one in MerisLevel1ProductPlugIn.
  2. Fixed a broken target link in help toc.xml.

…corrected one in MerisLevel1ProductPlugIn 2. Fixed broken target line in toc.xml
@knowles knowles changed the title Sentinel3 reader fixes Sentinel3 reader fixes (master) Jan 13, 2023
Copy link
Member

@marpet marpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, Danny.

regarding the expression change I have a comment.

@@ -17,7 +17,7 @@ public MerisLevel1ProductReader(MerisLevel1ProductPlugIn readerPlugIn) {
@Override
protected Product readProductNodesImpl() throws IOException {
final String dirName = getInputFileParentDirectory().getName();
if (dirName.matches("EN.*_(F|R)R(G|P|S).*")) {
if (dirName.matches("EN(1|V).*_ME(R|_)1?_(F|R)R(G|P|S|_)_(1P)?_.*")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have extended the expression to match the zip file names like
EN1_MDSI_MER_RR__1P_20111230T102706_20111230T111042_051430_0123_20180901T181455_0100.ZIP
But actually, this is not the folder name according to the format.
https://earth.esa.int/eogateway/documents/20142/37627/MERIS-Sentinel-3-Like-L1-andL2-PFS.pdf (section 3.2 page 11).

However, probably it does not disturb the usual reading. But it might be good to split both cases and make the expressions more specific to make it clearer. Also a unit level test would be good.

@knowles knowles changed the title Sentinel3 reader fixes (master) SEADAS: sentinel3 reader fixes (master) Jan 25, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants