SEADAS: seadas reader fixes (master) #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
knowles
commented
Jan 13, 2023
knowles
commented
- Fixed product naming in L1AHawkeyeFileReader.
- Recognizes level3 mapped files output by l3mapgen and adds band autogrouping.
- L1CPACEFileReader can now read SPEXOne and HARP2 files.
- Added support for PACE L1C.
- Added support for PACE L1B version 8.
…nd adds band autogrouping. 2. L1CPACEFileReader can read SPEXOne and HARP2 files. 3. Added support for PACE L1C. 4. Added support for PACE L1B version 8.
marpet
reviewed
Jan 24, 2023
| @@ -108,7 +101,7 @@ public void addGeocoding(final Product product) throws ProductIOException { | |||
| lats = geoNcFile.findVariable("geolocation_data/latitude"); | |||
| lons = geoNcFile.findVariable("geolocation_data/longitude"); | |||
|
|
|||
| //Use lat/lon with PixelGeoCoding | |||
| //Use lat/lon with TiePointGeoCoding | |||
There was a problem hiding this comment.
I think this change in the comment is not correct. In the end still a PixelGeoCoding is created.
By the way, the GeoCodingFactory should not be used anymore. It is better to use the ComponentGeoCoding. Probably we will soon change the implementation of GeoCodingFactory or maybe remove it at all. The new one is faster and more accurate.
knowles
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.