Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper returns the response body as a hash #12

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Add a helper returns the response body as a hash #12

merged 1 commit into from
Sep 1, 2017

Conversation

diegoc-am
Copy link
Contributor

I think the body is already a json string, therefore I only created a method to allow it to be hash

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 19, 2017
@SendGridDX
Copy link

SendGridDX commented Aug 19, 2017

CLA assistant check
All committers have signed the CLA.

@diegoc-am
Copy link
Contributor Author

Built the gem and ran the tests against sendgrid-ruby, nothing failed

sendgrid-ruby git:master ❯ bundle exec rake test                                                                                                             ⏎
/home/diego/.rbenv/versions/2.4.1/bin/ruby -I"lib:test" -I"/home/diego/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rake-0.9.6/lib" "/home/diego/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rake-0.9.6/lib/rake/rake_test_loader.rb" "test/sendgrid/test_sendgrid-ruby.rb" "test/sendgrid/helpers/mail/test_category.rb" "test/sendgrid/helpers/mail/test_mail.rb" "test/sendgrid/helpers/mail/test_personalizations.rb" 
Activating Prism (~20 seconds)
Prism started
Run options: --seed 8574

# Running:

................................................................................................................................................................................................................................................................

Finished in 14.516840s, 17.6347 runs/s, 18.3235 assertions/s.

256 runs, 266 assertions, 0 failures, 0 errors, 0 skips
Prism shut down

@diegoc-am
Copy link
Contributor Author

I think I've already signed the CLA before

@thinkingserious
Copy link
Contributor

Hello @belfazt,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@diegoc-am diegoc-am deleted the add-a-method-to-return-the-parsed-response-9 branch September 1, 2017 21:24
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants