Permit lodash version 3 to also be acceptable within npm #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiezane
added a commit
that referenced
this pull request
Apr 5, 2015
Permit lodash version 3 to also be acceptable within npm
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sendgrid-nodejs project leverages the following lodash functions:
Based on the lodash changelog,
_.isObjecthad some optimizations and_.mergehad some sanity checks introduced (which wouldn't impact the usage withinsendgrid.js).All tests pass.
This PR tells sendgrid to permit both the v2 and v3 of lodash, but tells it to prefer the v3 branch.