Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes secrets "\n" problem FIX. #773

Merged
merged 2 commits into from
Oct 19, 2018
Merged

kubernetes secrets "\n" problem FIX. #773

merged 2 commits into from
Oct 19, 2018

Conversation

0xDaksh
Copy link
Contributor

@0xDaksh 0xDaksh commented Oct 5, 2018 •
edited
Loading

Fixes: #732

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 5, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

reedsa
reedsa reviewed Oct 10, 2018
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Comment to address a minor spelling change and I'll be happy to approve after that.

TROUBLESHOOTING.md Outdated Show resolved Hide resolved
@reedsa reedsa added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 10, 2018
@reedsa reedsa added status: ready for deploy code ready to be released in next deploy and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 10, 2018
@devchas devchas added the type: question question directed at the library label Oct 11, 2018
@0xDaksh
Copy link
Contributor Author

0xDaksh commented Oct 19, 2018 •
edited
Loading

When is it getting merged?

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: easy fix is easy in difficulty and removed type: question question directed at the library labels Oct 19, 2018
@thinkingserious
Copy link
Contributor

Hello @DakshMiglani,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit b8bd5f2 into sendgrid:master Oct 19, 2018
@0xDaksh
Copy link
Contributor Author

0xDaksh commented Oct 19, 2018

@thinkingserious Sure, thanks.

@thinkingserious
Copy link
Contributor

Hello @DakshMiglani,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @DakshMiglani,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xDaksh @SendGridDX @thinkingserious @reedsa @devchas