Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "similar-code" issue in sendgrid/helpers/mail/mail.py #458

Closed
thinkingserious opened this issue Oct 27, 2017 · 1 comment
Closed

Fix "similar-code" issue in sendgrid/helpers/mail/mail.py #458

thinkingserious opened this issue Oct 27, 2017 · 1 comment
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Similar blocks of code found in 4 locations. Consider refactoring.

https://codeclimate.com/github/sendgrid/sendgrid-python/sendgrid/helpers/mail/mail.py#issue_59f2b5d8a7918a000100006a
@mbernier mbernier added difficulty: easy fix is easy in difficulty good first issue labels Oct 27, 2017
adiman9 pushed a commit to adiman9/sendgrid-python that referenced this issue Oct 29, 2017
fix similar code issue in mail.js helper as per sendgrid#458
0156636
@adiman9
Copy link

adiman9 commented Oct 29, 2017

PR #488

@galihmelon galihmelon mentioned this issue Oct 29, 2017
Closed
6 tasks
@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap and removed good first issue labels Feb 27, 2018
thinkingserious added a commit that referenced this issue Jul 12, 2018
@thinkingserious
Integrate PR #458
3b705ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempt to fix issues in sendgrid/helpers/mail/mail.py galihmelon/sendgrid-python
4 participants
@thinkingserious @mbernier @adiman9 @childish-sambino