Allows users to submit rfc822 formatted email addresses #348
Conversation
|
|
thinkingserious
added
status: code review request
|
@thinkingserious I am not sure what happened with the Travis build... looks like there's an env problem? |
sendgrid/helpers/mail/mail.py
Outdated
| self.email = email | ||
| if name is not None: | ||
| self.name = name | ||
| if not name |
There was a problem hiding this comment.
Should be if not name:
|
Updated, thanks! |
Also realized, we already checked that name exists... so we don't have to check again
The class was not using get/set methods for all calls. As well, email and name were not initialized. This is now rectified.
My guess is this should be one line?
This is failing in #348
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 81.54% 81.98% +0.43%
==========================================
Files 9 9
Lines 981 999 +18
Branches 156 160 +4
==========================================
+ Hits 800 819 +19
Misses 90 90
+ Partials 91 90 -1
Continue to review full report at Codecov.
|
email class now allows empty instantiation without error If a name is passed, i.e. an email with no '@', then the name gets set rather than defaulting to email param
|
@thinkingserious I added a ridiculous number of tests and even found something I missed. You win. Fine. Are you happy!!? 🥇 |
|
Hello @mbernier, |
|
It's MERGED!!! |
Closes #277