Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #217, Add support for IO objects set as Attachment#content #231

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Fix #217, Add support for IO objects set as Attachment#content #231

merged 1 commit into from
Oct 22, 2018

Conversation

awj
Copy link
Contributor

@awj awj commented Oct 22, 2017

For non-binary files, this will re-encode the content as UTF-8 to match the expected type on the server.

Trying to use the smallest amount of the IO interface required so custom file-like objects more reliably work as expected.

@awj
Add support for IO objects set as Attachment#content
3327a17 
For non-binary files, this will re-encode the content as
UTF-8 to match the expected type on the server.
@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 22, 2017
@thinkingserious
Copy link
Contributor

@awj

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

clee
clee reviewed Feb 12, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit e9aa970 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @awj,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@awj awj deleted the feature/217-attachment-file-handling branch October 23, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee clee clee left review comments

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awj @thinkingserious @clee