Update repos to HTTPS #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
suggested changes
Dec 16, 2017
|
ping @thomasriley |
|
closing in favor of #602 while there are some advantages of pulling it over https the fact that we now pull the pgp key over https is enough for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #590
Update the repos use for Sensu (non-enterprise) to HTTPS
Description
Updated the default attributes to use the HTTPS repos and updated the Chefspec to validate the URL that is used.
Motivation and Context
Good practice to use HTTPS!
How Has This Been Tested?
Updated the ChefSpec tests to validate the URL I updated in the attributes was indeed HTTPS.
Types of changes
Checklist: