Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify precedence for environment variables #3821

Closed
2 of 4 tasks
hillaryfraley opened this issue May 2, 2022 · 2 comments · Fixed by #3834
Closed
2 of 4 tasks

Clarify precedence for environment variables #3821

hillaryfraley opened this issue May 2, 2022 · 2 comments · Fixed by #3834

Comments

@hillaryfraley
Copy link
Contributor

hillaryfraley commented May 2, 2022

Description

A user recently commented Runtime env_vars defined for a slack handler's definition in backend lose to event's entity annotations if latter are present.

The docs discuss precedence related to environment variables in https://docs.sensu.io/sensu-go/latest/observability-pipeline/observe-schedule/backend/#create-overrides.

Category

This is an issue with:

  • errata (error in doc content)
  • new doc (requires a completely new doc)
  • update (add missing or refresh existing content)
  • improvement (improve docs content or format)

Affected pages

https://docs.sensu.io/sensu-go/latest/observability-pipeline/observe-schedule/backend/#create-overrides

Corrections needed

First need to confirm where the clarifications about precedence belong in the docs.

Then, may need to update https://docs.sensu.io/sensu-go/latest/observability-pipeline/observe-schedule/backend/#create-overrides alone, https://docs.sensu.io/sensu-go/latest/observability-pipeline/observe-schedule/backend/#create-overrides in addition to another section in the docs (or a new section), or different sections altogether.

Additional context

HS 28580

@hillaryfraley
Copy link
Contributor Author

See sensu/sensu-slack-handler#42. I should confirm this is correct (per-entity/per-check annotations always override env vars and handler commands) and if so, add it to https://docs.sensu.io/sensu-go/latest/plugins/assets/

@hillaryfraley
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant