Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded etcd has a critical bug #3278

Closed
echlebek opened this issue Sep 13, 2019 · 5 comments · Fixed by #3343
Closed

Embedded etcd has a critical bug #3278

echlebek opened this issue Sep 13, 2019 · 5 comments · Fixed by #3343
Labels
bug
Milestone
5.15.0

Comments

@echlebek
Copy link
Contributor

See etcd-io/etcd#9949

Upgrading to the latest patch release should mitigate this bug.
@echlebek echlebek added the bug label Sep 13, 2019
@echlebek
Copy link
Contributor Author

echlebek commented Oct 6, 2019

@portertech, I think that we should try to address this for 5.15.

@echlebek echlebek added this to the 5.15.0 milestone Oct 6, 2019
@palourde
Copy link
Contributor

palourde commented Oct 9, 2019

Should we use this opportunity to upgrade to v3.4.2?

@echlebek
Copy link
Contributor Author

echlebek commented Oct 9, 2019

I think we should yes.

@echlebek echlebek modified the milestones: 5.15.0, 5.14.1 Oct 16, 2019
@echlebek
Copy link
Contributor Author

echlebek commented Oct 16, 2019 •
edited
Loading

We are going to use the latest 3.3 release branch to target 5.14.1 for this.

@echlebek echlebek modified the milestones: 5.14.1, 5.15.0 Oct 17, 2019
echlebek added a commit that referenced this issue Oct 17, 2019
@echlebek
Upgrade etcd to 3.3.17
b42e3b1 
I originally intended to upgrade etcd to 3.4.2, but at this time,
the module is broken, and cannot be included, under the original
import path, or the new go.etcd.io import path.

See etcd-io/etcd#11154 for more info.

Closes #3278

Signed-off-by: Eric Chlebek <[email protected]>
@echlebek echlebek mentioned this issue Oct 17, 2019
Merged
@portertech
Copy link
Contributor

@echlebek looking for updates here.

@echlebek echlebek mentioned this issue Oct 21, 2019
Closed
echlebek added a commit that referenced this issue Oct 21, 2019
@echlebek
Upgrade etcd to 3.3.17 (#3343)
f62e680 
I originally intended to upgrade etcd to 3.4.2, but at this time,
the module is broken, and cannot be included, under the original
import path, or the new go.etcd.io import path.

See etcd-io/etcd#11154 for more info.

Closes #3278

Signed-off-by: Eric Chlebek <[email protected]>

* Re-write tracing middleware tests to use prometheus_client/testutil (#3342)

The testutil package was introduced in v0.9 and exposes some helpers for
for writing simple unit tests.

Signed-off-by: James Phillips <[email protected]>
echlebek added a commit that referenced this issue Nov 1, 2019
@echlebek
Upgrade etcd to 3.3.17 (#3343)
56cf71f 
I originally intended to upgrade etcd to 3.4.2, but at this time,
the module is broken, and cannot be included, under the original
import path, or the new go.etcd.io import path.

See etcd-io/etcd#11154 for more info.

Closes #3278

Signed-off-by: Eric Chlebek <[email protected]>

* Re-write tracing middleware tests to use prometheus_client/testutil (#3342)

The testutil package was introduced in v0.9 and exposes some helpers for
for writing simple unit tests.

Signed-off-by: James Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.15.0
Development

Successfully merging a pull request may close this issue.

Upgrade etcd to 3.3.17 sensu/sensu-go
3 participants
@portertech @echlebek @palourde