Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework sensu_silenced name handling #1015

Closed
treydock opened this issue Nov 16, 2018 · 1 comment
Closed

Rework sensu_silenced name handling #1015

treydock opened this issue Nov 16, 2018 · 1 comment

Comments

@treydock
Copy link
Collaborator

The name passed like this:

      sensu_silenced { 'test':
        ensure => 'present',
        subscription => 'entity:sensu_agent',
      }

Will be replaced in metadata with entity:sensu_agent:*. The name passed during creation isn't used, and based on docs name is a #{subscription}:#{check}. To avoid confusion and inconsistent behavior the name of a sensu_silenced resource should match the convention that one would see when looking at things through sensuctl.

treydock added a commit to treydock/sensu-puppet that referenced this issue Nov 16, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue Nov 17, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue Jan 8, 2019
treydock added a commit to treydock/sensu-puppet that referenced this issue Jan 8, 2019
treydock added a commit to treydock/sensu-puppet that referenced this issue Jan 10, 2019
treydock added a commit to treydock/sensu-puppet that referenced this issue Jan 13, 2019
@treydock
Copy link
Collaborator Author

Instead of changing naming it was just documented how the naming works and tests added to validate what is documented. Closing via #1041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant