Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow merging of hiera configs instead of only taking lowest in hierarchy #366

Closed
ghost opened this issue Jun 12, 2015 · 6 comments
Closed

Comments

@ghost
Copy link

ghost commented Jun 12, 2015

specifically for subscriptions and client-custom fields.

@ghost
Copy link
Author

ghost commented Jun 12, 2015

PR to follow (small change)

@rk295
Copy link
Contributor

rk295 commented Jun 15, 2015

@pdaugavietis have you made this work yet? I've just come across this, and merging of classes would be fantastic.

@ghost
Copy link
Author

ghost commented Jun 15, 2015

i've got it working locally but not the tests :( i'm refactoring now to
see if the tests pass as-is, and then i can add the additional stuff...

On Mon, Jun 15, 2015 at 11:38 AM, Robin Kearney [email protected]
wrote:

@pdaugavietis https://github.com/pdaugavietis have you made this work
yet? I've just come across this, and merging of classes would be fantastic.


Reply to this email directly or view it on GitHub
#366 (comment).

@ghost ghost mentioned this issue Jun 23, 2015
@ghost
Copy link
Author

ghost commented Jun 23, 2015

okay - PR is passing now, and functioning as desired locally as well. thought i'd done this at least a week ago the first time, but now it's passing :)

@ghost
Copy link
Author

ghost commented Jun 25, 2015

okay - this is now refactored to have 2 new options - $sensu::merge_{subscriptions,client_custom} that will merge all levels of hiera, instead of default taking lowest level as override(s)

@ghost
Copy link
Author

ghost commented Jul 7, 2015

attacking this another way - closing ticket and pr

@ghost ghost closed this as completed Jul 7, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant