issue with "Do not use 'handle' and 'handlers' together. Your 'handle' value has been overridden with 'handlers'"

[ghost]

In a nutshell - this doesn't make sens(u)e to me -- why was it added to say that if you have handlers, you can't diable the handling of a check? I think it was added on commit #a9b4089cb3ff7ae28a56b8d6d535478953c8f6b8 but i don't agree with it. I should accept whatever i tell it to do, and not impose a logic block - at least remove the 'return' there, and issue the warning for 'style' points or something.

https://github.com/sensu/sensu-puppet/blob/master/lib/puppet/provider/sensu_check/json.rb#L179

[jlambert121]

@countryHick I think this is because the handle attribute used to be used for "handler", but I could be mistaken - it's been a while. A PR is likely warranted with an update to fix this.

[ghost]

yeah - i'll make one later today methinks -- i've locally done this and works much better, cause now you can handle:false, aggregate:true - and your failed aggregates aren't alerting anymore :)

[jlambert121]

@countryHick I'm going to try to tag a 2.0 version of this module hopefully later this week. Do you have a few minutes to do a PR for this? I think a 2.0 version is the perfect time to correct this.

[ghost]

hopefully - i'll try for today/tonight...

On Mon, Aug 31, 2015 at 9:04 AM, Justin Lambert [email protected]
wrote:

@countryHick https://github.com/countryHick I'm going to try to tag a
2.0 version of this module hopefully later this week. Do you have a few
minutes to do a PR for this? I think a 2.0 version is the perfect time to
correct this.

—
Reply to this email directly or view it on GitHub
#391 (comment).

[jlambert121]

@countryHick Does #422 work for you? I want to close this one out and then am going to tag a 2.0 release finally.

[ghost]

Yep - that's the one