Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins should install before checks #463

Closed
benh57 opened this issue Jan 13, 2016 · 1 comment
Closed

plugins should install before checks #463

benh57 opened this issue Jan 13, 2016 · 1 comment
Assignees
@jeffmccune

Comments

@benh57
Copy link

benh57 commented Jan 13, 2016

In the current puppet module the checks are set up before the plugins.

This causes some failing checks when a node is being configured, because some of my checks depend on the plugins. (which are shell scripts defined with a template path via the plugins hash)

To fix, the puppet module should install the plugins before it creates any checks or even starts the client up.
@jlambert121
Copy link
Contributor

A PR would be wonderful if you would!

@rowleyaj rowleyaj mentioned this issue Sep 16, 2016
Closed
@jeffmccune jeffmccune self-assigned this Jul 17, 2017
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jul 17, 2017
@jeffmccune
(sensu#463) Ensure sensu::plugins are managed before checks
a1b12b6 
Without this patch plugins may be managed after the checks which use them.  This
patch addresses the problem by adding a well known inert resource named
`Anchor[plugins_before_checks]`.  The sensu::check and sensu_check_config type
are managed after this anchor.  The sensu::plugin defined type is managed
before this anchor.  The anchor approach has been implemented over collections
to avoid realizing resources which the end user may be using.

Resolves sensu#463
@jeffmccune jeffmccune mentioned this issue Jul 17, 2017
Merged
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jul 19, 2017
@jeffmccune
(sensu#463) Ensure sensu::plugins are managed before checks
0788152 
Without this patch plugins may be managed after the checks which use them.  This
patch addresses the problem by adding a well known inert resource named
`Anchor[plugins_before_checks]`.  The sensu::check and sensu_check_config type
are managed after this anchor.  The sensu::plugin defined type is managed
before this anchor.  The anchor approach has been implemented over collections
to avoid realizing resources which the end user may be using.

Resolves sensu#463
ghoneycutt added a commit that referenced this issue Jul 19, 2017
@ghoneycutt
Merge pull request #755 from jeffmccune/463_plugins_before_checks
998ea0c 
(#463) Ensure sensu::plugins are managed before checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffmccune jeffmccune

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jeffmccune @cwjohnston @ghoneycutt @benh57 @jlambert121