Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md with compatibility #568

Closed
jaxxstorm opened this issue Oct 23, 2016 · 0 comments · Fixed by #571
Closed

Update README.md with compatibility #568

jaxxstorm opened this issue Oct 23, 2016 · 0 comments · Fixed by #571
Assignees
@jeffmccune
Milestone
2.2.0

Comments

@jaxxstorm
Copy link
Contributor

We need a template in the README.md with supported versions so it's clear which version of the module supports which version of sensu

Nice example: https://github.com/solarkennedy/puppet-consul#compatibility
@jaxxstorm jaxxstorm added this to the 2.2.0 milestone Oct 23, 2016
This was referenced Oct 31, 2016
Closed
Merged
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jul 13, 2017
@jeffmccune
(sensu#568) Improve rabbitmq clustering robustness
9feab34 
Without this patch, Puppet errors out when both `sensu::rabbitmq_password`, or
any of the `sensu::rabbitmq_*` parameters are specified along with
`sensu::rabbitmq_cluster`.  The error is:

    Error: /Stage[main]/Sensu::Rabbitmq::Config/Sensu_rabbitmq_config[sensu-server.example.com]: Could not evaluate: no implicit conversion of String into Integer
    /vagrant/lib/puppet/provider/sensu_rabbitmq_config/json.rb:137:in `[]'
    /vagrant/lib/puppet/provider/sensu_rabbitmq_config/json.rb:137:in `password'

This patch addresses the problem by changing sensu::rabbitmq::config to ignore
sensu::rabbitmq_* class parameters when the cluster configuration is specified
via `sensu::rabbitmq_cluster`.

Resolves sensu#568
@jeffmccune jeffmccune mentioned this issue Jul 13, 2017
Merged
@jeffmccune jeffmccune self-assigned this Jul 13, 2017
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jul 13, 2017
@jeffmccune
(sensu#568) Improve rabbitmq clustering robustness
7f1edd9 
Without this patch, Puppet errors out when both `sensu::rabbitmq_password`, or
any of the `sensu::rabbitmq_*` parameters are specified along with
`sensu::rabbitmq_cluster`.  The error is:

    Error: /Stage[main]/Sensu::Rabbitmq::Config/Sensu_rabbitmq_config[sensu-server.example.com]: Could not evaluate: no implicit conversion of String into Integer
    /vagrant/lib/puppet/provider/sensu_rabbitmq_config/json.rb:137:in `[]'
    /vagrant/lib/puppet/provider/sensu_rabbitmq_config/json.rb:137:in `password'

This patch addresses the problem by changing sensu::rabbitmq::config to ignore
sensu::rabbitmq_* class parameters when the cluster configuration is specified
via `sensu::rabbitmq_cluster`.

Resolves sensu#598
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jul 13, 2017
@jeffmccune
(sensu#568) Improve rabbitmq clustering robustness
c3366cb 
Without this patch, Puppet errors out when both `sensu::rabbitmq_password`, or
any of the `sensu::rabbitmq_*` parameters are specified along with
`sensu::rabbitmq_cluster`.  The error is:

    Error: /Stage[main]/Sensu::Rabbitmq::Config/Sensu_rabbitmq_config[sensu-server.example.com]: Could not evaluate: no implicit conversion of String into Integer
    /vagrant/lib/puppet/provider/sensu_rabbitmq_config/json.rb:137:in `[]'
    /vagrant/lib/puppet/provider/sensu_rabbitmq_config/json.rb:137:in `password'

This patch addresses the problem by changing sensu::rabbitmq::config to ignore
sensu::rabbitmq_* class parameters when the cluster configuration is specified
via `sensu::rabbitmq_cluster`.

Resolves sensu#598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffmccune jeffmccune

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Add sensu compatibility info in README.md ttarczynski/sensu-puppet
2 participants
@jeffmccune @jaxxstorm