Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensu_enterprise_dashboard_api type should use host as namevar, not name #638

Closed
dhgwilliam opened this issue Apr 17, 2017 · 3 comments · Fixed by #715
Closed

sensu_enterprise_dashboard_api type should use host as namevar, not name #638

dhgwilliam opened this issue Apr 17, 2017 · 3 comments · Fixed by #715
Assignees

Comments

@dhgwilliam
Copy link
Contributor

Because name is used as namevar, it is not possible to have multiple API endpoints represented as a single datacenter in the enterprise dashboard.

@jeffmccune
Copy link
Collaborator

@dhgwilliam I'm working on this presently. Thanks for the great start, I've rebased your work on master and will build from there preserving your commits.

I'm thinking about host being the namevar, and I'm wondering if it's sufficient? That is to say, have you ever run into a situation where multiple dashboards run on the same hostname or IP, but under different port numbers?

My gut tells me the fully qualified URL of the API should be the namevar. The full URL is guaranteed to be unique for the resource. The URL, however, leads me down the path of composite namevars.

I'll spend half an hour looking into if composite namevars are feasible, but would love your insight before I get too far down the rabbit hole. Does a URL namevar address an issue that doesn't exist, or solve this issue once and for all? (Or something else?)

@jeffmccune
Copy link
Collaborator

In progress.

jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jul 6, 2017
Without this patch it is not possible to manage multiple
sensu::enterprise::dashboard::api resources in the same datacenter
because the resources conflict over the namevar.  This patchset
addresses the problem by changing the namevar to the `host` and
establishing the `datacenter` attribute.

An example of how to exercise this behavior is located in
tests/sensu-dashboard-api.pp
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jul 6, 2017
Without this patch it is not possible to manage multiple
sensu::enterprise::dashboard::api resources in the same datacenter
because the resources conflict over the namevar.  This patchset
addresses the problem by changing the namevar to the `host` and
establishing the `datacenter` attribute.

An example of how to exercise this behavior is located in
tests/sensu-enterprise-dashboard-multi-api.pp

resolves sensu#638
closes sensu#651
closes sensu#584
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jul 6, 2017
Without this patch it is not possible to manage multiple
sensu::enterprise::dashboard::api resources in the same datacenter
because the resources conflict over the namevar.  This patchset
addresses the problem by changing the namevar to the `host` and
establishing the `datacenter` attribute.

An example of how to exercise this behavior is located in
tests/sensu-enterprise-dashboard-multi-api.pp

resolves sensu#638
closes sensu#651
closes sensu#584
ghoneycutt added a commit that referenced this issue Jul 6, 2017
…type

(#638) Enable multiple Sensu Enterprise Dashboard API endpoints
@ghoneycutt
Copy link
Collaborator

Released in v2.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants