Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the sensu-plugin gem is incorrectly installed with the system ruby instead of the embedded ruby #688

Closed
ghoneycutt opened this issue Jun 27, 2017 · 4 comments
Closed

the sensu-plugin gem is incorrectly installed with the system ruby instead of the embedded ruby #688

ghoneycutt opened this issue Jun 27, 2017 · 4 comments

Comments

@ghoneycutt
Copy link
Collaborator

We should install the plugin and anything else using the embedded ruby and not the system ruby.
@jeffmccune
Copy link
Collaborator

@ghoneycutt Is the scope of this the default behavior of the module to be released to end users, or restricted to the vagrant environment, e.g. tests/sensu-client.pp which would need sensu_plugin_provider => sensu_gem added?

jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jun 28, 2017
@jeffmccune
(sensuGH-688) Default sensu-plugin gem to use sensu_gem provider
04022e4 
Without this patch the behavior of sensu-plugin is managed by the
default package provider for the system, e.g. gem.  This patch changes
the default behavior to use the embedded ruby version at
`/opt/sensu/embedded/bin/gem` via the built in provider.
@jeffmccune jeffmccune mentioned this issue Jun 28, 2017
Merged
@jeffmccune
Copy link
Collaborator

PR-694 is ready for review.

@ghoneycutt
Copy link
Collaborator Author

Not just vagrant, you're on the right track here by only using the embedded ruby.

ghoneycutt added a commit that referenced this issue Jun 28, 2017
@ghoneycutt
Merge pull request #694 from jeffmccune/use_embedded_ruby_for_sensu_p…
319ba6d 
…lugin

(GH-688) Default sensu-plugin gem to use sensu_gem provider
jeffmccune added a commit to jeffmccune/sensu-puppet that referenced this issue Jun 29, 2017
@jeffmccune
(sensuGH-688) Default sensu-plugin gem to use sensu_gem provider
a210dfe 
Without this patch the default behavior is to manage sensu-plugin using
the system `gem` command via the gem provider.  This is a problem
because this version combination is unknown and untested.  The embedded
ruby should be used for supportability and predictable behavior.

This patch changes the default behavior to use the embedded ruby version
at `/opt/sensu/embedded/bin/gem` via the `sensu_gem` provider shipped in
this module.

closes sensu#688
@ghoneycutt
Copy link
Collaborator Author

Released in v2.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffmccune @ghoneycutt